mac: sanitize rpaths by default #1980
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is opt-in in delocate-wheel, but should probably be the default to avoid leaking CI paths into rpath of shipped binaries more consistent with default behavior of auditwheel
|
This was added in 3.8+ supporting versions and we match manylinux (so 3.6+ currently). |
|
I reckon this would be better added as the default at the delocate side, I made a comment here: matthew-brett/delocate#101 (comment) |
|
Makes sense! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is opt-in in delocate-wheel (I'd say it should probably be default there, too), but should probably be the default to avoid leaking CI paths into rpath of shipped binaries
This is consistent with default behavior of auditwheel.
upstream issue suggests tools like cibuildwheel opt-in by default.