Fix directories not cleaned up after test #12773
Merged
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewhughes934
force-pushed
the
fix-tests-unable-to-cleanup
branch
from
6279494
to
cb9cbc3
Compare
uranusjr
approved these changes
Jun 19, 2024
|
Failures are not related (caused by a CPython change). |
Thanks, I was just looking into this (I see you've raised a PR to address it) |
matthewhughes934
force-pushed
the
fix-tests-unable-to-cleanup
branch
from
cb9cbc3
to
3158114
Compare
The `test_rmtree_errorhandler_reraises_error` test creates a directory
that the user is unable to read under pytest's `tmpdir`. Once the test
session end pytest will fail to clean this up due to permissions error
and emit a warning like:
/home/user/src/pip/.nox/test-3-12/lib/python3.12/site-packages/_pytest/pathlib.py:98: PytestWarning: (rm_rf) error removing /tmp/pytest-of-user/garbage-23e907a9-3e54-40bd-89e4-d70150b10f61/test_rmtree_errorhandler_rerai0
<class 'OSError'>: [Errno 39] Directory not empty: 'test_rmtree_errorhandler_rerai0'
warnings.warn(
This restores behaviour from b5c1c76,
that commit mentions fixing 'failing tests' though I'm not sure which
failures that addresses and if they were related to restoring the file
permissions.
Also make consistent use of `pathlib.Path` methods rather than mixing
them with `os.` methods
matthewhughes934
force-pushed
the
fix-tests-unable-to-cleanup
branch
from
3158114
to
8cdf797
Compare
|
latest change is just me rebasing on |
ichard26
reviewed
Jun 23, 2024
ichard26
approved these changes
Jun 23, 2024
ichard26
added
C: tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_rmtree_errorhandler_reraises_errortest creates a directorythat the user is unable to read under pytest's
tmpdir. Once the testsession end pytest will fail to clean this up due to permissions error
and emit a warning like:
This restores behaviour from b5c1c76,
that commit mentions fixing 'failing tests' though I'm not sure which
failures that addresses and if they were related to restoring the file
permissions.
Also make consistent use of
pathlib.Pathmethods rather than mixingthem with
os.methods