Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade requests to 2.32.3 #12784

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Upgrade requests to 2.32.3 #12784

merged 3 commits into from
Jun 25, 2024

Conversation

notatallshaw
Copy link
Member

Maybe fix #12779

@notatallshaw
Copy link
Member Author

notatallshaw commented Jun 22, 2024

@pradyunsg this is pretty much confirmed to fix #12779, I strongly think this should go into a 24.1.1 release

@uranusjr any further thoughts on fixing Windows CI given python/cpython#67693

@sweetlilmre (@ed wrong person) @sethmlarson truststore didn't break this, but if you can think of a test to catch this kind of breakage in the future that would be appreciaited, though I don't think it should hold this PR up

@ichard26
Copy link
Member

Pradyun is OOO until the later half of next week. We'll have to defer to any other pip committer deciding whether a bugfix release is necessary.

Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm kinda-sorta around but yea... I'll only be able to make time to cut a release with this sometime next week.

@notatallshaw
Copy link
Member Author

CI is now green

@pradyunsg pradyunsg merged commit 300ed75 into pypa:main Jun 25, 2024
28 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[24.1] self signed certificates are no longer loaded
3 participants