Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove secho from pipenv.utils.shell #6170

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Remove secho from pipenv.utils.shell #6170

merged 1 commit into from
Jun 5, 2024

Conversation

aidencullo
Copy link
Contributor

@aidencullo aidencullo commented Jun 4, 2024 •
edited
Loading

The issue

Remove all references to click in favor of console in pipenv.utils.shell

The fix

Straightforward substitution of equivalent console calls where required. Continuation of #5804.

@aidencullo aidencullo marked this pull request as ready for review June 4, 2024 22:38
@oz123 oz123 self-requested a review June 5, 2024 12:56
@oz123 oz123 merged commit 2c04a63 into pypa:main Jun 5, 2024
19 checks passed
@aidencullo aidencullo deleted the finish-secho-cleanup branch July 8, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oz123 oz123 Awaiting requested review from oz123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aidencullo @oz123