Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses RST substitution to put badges in 1 line #4312

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

shenxianpeng
Copy link
Contributor

@shenxianpeng shenxianpeng commented Apr 19, 2024

Summary of changes

It might be some update to Github's RST renderer caused badges to display in multiple lines. uses RST substitution to put badges in 1 line.

Before the change

image

After the change

image

Pull Request Checklist

@abravalheri
Copy link
Contributor

abravalheri commented Apr 19, 2024

Thank you very much @shenxianpeng! That was a good catch, I haven't noticed this before your PR.

I think that is a fine change, but I wonder if the best approach would not be to notify GitHub about this regression? (The rationale is that with this change we fix setuptools, but there is a lot of other repositories out there with the same setup; so if GitHub fixes it at the source, everyone benefits).

Should we notify GitHub first and then see their feedback before merging the change?

UPDATE: github/markup#1801

@shenxianpeng
Copy link
Contributor Author

That would be best if GitHub could address this issue.

@shenxianpeng
Copy link
Contributor Author

I see that there are nearly no replies from the maintainer under https://github.com/github/markup/issues.
Perhaps reposting github/markup#1801 to the GitHub community discussions would get it more widespread attention.
I see other questions about RST, such as 113792 (another recent regression), but not this one.

@abravalheri
Copy link
Contributor

Thanks @shenxianpeng, I found an open discussion on the topic and reported the problem description there: https://github.com/orgs/community/discussions/114690

@webknjaz
Copy link
Member

It might be some update to Github's RST renderer caused badges to display in multiple lines

Yes, I noticed this in many other of my projects. It also looks like they've broken rendering of other things and the overall support of RST on GitHub has always been quite limited.
So I think this is a good change for now but in the future it might make sense to migrate to MyST and regular Markdown...

@abravalheri abravalheri merged commit 2760eef into pypa:main Apr 24, 2024
21 checks passed
@abravalheri
Copy link
Contributor

abravalheri commented Apr 24, 2024

Thank you @shenxianpeng, let's merge it for now... I don't know how long the discussion on the github site will take.

Also the behaviour seems to be an intended change in docutils (¿ possibly ?) as per github/markup#1801 (comment)

@shenxianpeng shenxianpeng deleted the inline-badges branch May 27, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants