Disallow blanket and unused suppressions #4526
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
disallow-blanket-suppressions
branch
from
07f7273
to
94d4d75
Compare
Avasam
changed the title
|
Thank you. Let's wait for the feedback in skeleton. |
Avasam
force-pushed
the
disallow-blanket-suppressions
branch
from
863e532
to
881c06e
Compare
@abravalheri jaraco/skeleton#136 has been merged |
Avasam
force-pushed
the
disallow-blanket-suppressions
branch
4 times, most recently
from
90de434
to
722304b
Compare
Avasam
commented
Aug 27, 2024
Comment on lines
+289
to
+292
| if not namespaces: | ||
| from setuptools.discovery import PackageFinder | ||
| else: | ||
| from setuptools.discovery import PackageFinder # type: ignore | ||
| from setuptools.discovery import PEP420PackageFinder as PackageFinder |
There was a problem hiding this comment.
Avoids python/mypy#6232
Avasam
force-pushed
the
disallow-blanket-suppressions
branch
from
1620a13
to
7758810
Compare
…ow-blanket-suppressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
As title says.
imo
PGH003,PGH004,RUF100andRUF101should be part of the skeleton base rules.Same for mypy's(already part of skeleton)warn_unused_ignores = Trueandenable_error_code = ignore-without-codeif not in strict modeIncludes #4604, please merge that one first
Pull Request Checklist
newsfragments/.(See documentation for details)