Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only test against a single recent pytest and coverage.py #182

Closed
wants to merge 3 commits into from

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Nov 21, 2017

I'd like to suggest running 146 build jobs is a bit unweildy. It uses nearly 7 hours of CI time in total, about 1.5 hours from start to finish (eg.).

It's testing 6 Python versions against 4 pytest versions and 6 coverage.py versions (plus 2 for docs/checks), 6 * 4 * 6 + 2=146.

  • Is it really necessary to test against all those old versions of pytest and coverage.py?

  • Does pytest-cov need to make promises to support so old releases?

  • Does pytest promise to support 3 old releases, or coverage.py 5 old releases, or just the most recent?

Further, some three dozen of the build jobs are failing, giving less confidence in the CI/tests as a whole.

https://docs.travis-ci.com/user/customizing-the-build/#Build-Matrix says:

All build matrixes are currently limited to a maximum of 200 JOBS for both private and public repositories. If you are on an open-source plan, please remember that Travis CI provides this service free of charge to the community. So please only specify the matrix you actually need.

I'd recommend only testing against a single, recent version of pytest and coverage.py, 6 * 1 * 1 + 2=8, only about 22 minutes total and 6 minutes start to finish (eg.). Of course, I don't know the full history, so perhaps one old extra version may be necessary, but 146 seems a bit much.

Thank you!

@ionelmc
Copy link
Member

ionelmc commented Nov 24, 2017

Some fair arguments here, I'll include some of these changes (#178 already drops some stuff out).

@ionelmc ionelmc closed this in 73e9d66 Nov 24, 2017
@hugovk hugovk deleted the fewer-builds branch August 30, 2018 13:06
@hugovk hugovk mentioned this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants