Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error assertion handling in approx when None in dict comparison #11178

Merged
merged 3 commits into from
Jul 8, 2023

Commits on Jul 7, 2023

  1. Fix error assertion handling in approx when None in dict comparison

    Dict comparsion in the ApproxMapping class did not check if values were None before attempting to subtract for max_abs_diff stat, which was throwing an TypeError instead of being handled by pytest error assertion. Check for None has been added before these calculations, so that None will properly show as Obtained/Expected in pytest assert message
    kenny-y-dev committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    c5b1309 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    db37e34 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2023

  1. Update src/_pytest/python_api.py

    Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
    kenny-y-dev and nicoddemus committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    d426544 View commit details
    Browse the repository at this point in the history