Commits on Jun 4, 2024

1. [8.2.x] fixtures: fix catastrophic performance problem in `reorder_it… …

   …ems`
   
   Manual minimal backport from commit e89d23b.
   
   Fix pytest-dev#12355.
   
   In the issue, it was reported that the `reorder_items` has quadratic (or
   worse...) behavior with certain simple parametrizations. After some
   debugging I found that the problem happens because the "Fix
   items_by_argkey order" loop keeps adding the same item to the deque,
   and it reaches epic sizes which causes the slowdown.
   
   I don't claim to understand how the `reorder_items` algorithm works, but
   if as far as I understand, if an item already exists in the deque, the
   correct thing to do is to move it to the front. Since a deque doesn't
   have such an (efficient) operation, this switches to `OrderedDict` which
   can efficiently append from both sides, deduplicate and move to front.

   

   bluetech committed Jun 4, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 153a436
   • Browse repository at this point

   Copy the full SHA

   153a436 View commit details

   Browse the repository at this point in the history