Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: pytest >=8.1.0 displays no diff for AssertionError with `--impor… #12716

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Fix: pytest >=8.1.0 displays no diff for AssertionError with `--impor… #12716

merged 1 commit into from
Aug 30, 2024
+51 −1

Conversation

dongfangtianyu
Copy link
Contributor

closes #12659

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Aug 15, 2024
nicoddemus
nicoddemus requested changes Aug 16, 2024
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @dongfangtianyu!

Please take a look at the comments.

src/_pytest/assertion/rewrite.py Outdated Show resolved Hide resolved
testing/test_pathlib.py Outdated Show resolved Hide resolved
testing/test_pathlib.py Show resolved Hide resolved
changelog/12659.bugfix.rst Outdated Show resolved Hide resolved
@nicoddemus nicoddemus added the backport 8.3.x apply to PRs at any point; backports the changes to the 8.3.x branch label Aug 16, 2024
@dongfangtianyu
Copy link
Contributor Author

Thanks @nicoddemus ,resubmitted according to the comments

nicoddemus
nicoddemus approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dongfangtianyu!

@nicoddemus nicoddemus merged commit 9a444d1 into pytest-dev:main Aug 30, 2024
29 checks passed
@patchback Patchback
Copy link

patchback bot commented Aug 30, 2024 •
edited
Loading

Backport to 8.3.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/8.3.x/9a444d113658be6ccb8dc9f57ed118a1ef17c94c/pr-12716

Backported as #12755

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 30, 2024
@dongfangtianyu @patchback
Fix assertion rewriting with importlib mode (#12716)
47ca377 
Fixes #12659

(cherry picked from commit 9a444d1)
@patchback patchback bot mentioned this pull request Aug 30, 2024
Merged
nicoddemus pushed a commit that referenced this pull request Aug 30, 2024
@patchback @dongfangtianyu
Fix assertion rewriting with importlib mode (#12716) (#12755)
bf379f4 
Fixes #12659

(cherry picked from commit 9a444d1)

Co-authored-by: dongfangtianyu <7629022+dongfangtianyu@users.noreply.github.com>
@dongfangtianyu dongfangtianyu deleted the bugfix-12659 branch September 9, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
backport 8.3.x apply to PRs at any point; backports the changes to the 8.3.x branch bot:chronographer:provided (automation) changelog entry is part of PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pytest >=8.1.1 displays no diff for AssertionError with --import-mode=importlib
2 participants
@dongfangtianyu @nicoddemus