Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 8.3.3 #12789

Closed
wants to merge 3 commits into from
Closed

Prepare release 8.3.3 #12789

wants to merge 3 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 8, 2024

Created by the prepare release pr workflow.

Once all builds pass and it has been approved by one or more maintainers, start the deploy workflow, using these parameters:

  • Use workflow from: release-8.3.3.
  • Release version: 8.3.3.

Or execute on the command line:

gh workflow run deploy.yml -r release-8.3.3 -f version=8.3.3

After the workflow has been approved by a core maintainer, the package will be uploaded to PyPI automatically.

@nicoddemus nicoddemus closed this Sep 8, 2024
@nicoddemus nicoddemus reopened this Sep 8, 2024
@nicoddemus
Copy link
Member

nicoddemus commented Sep 9, 2024

There is a bug in pypa/gh-action-pypi-publish@v1.10.0 related to the attestations feature, which needs to be updated to 1.10.1.

Will update it after getting approval from other maintainers. 👍

EDIT: cherry-picked 63a5e11.

…12790)

Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.10.0 to 1.10.1.
- [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases)
- [Commits](pypa/gh-action-pypi-publish@v1.10.0...v1.10.1)

---
updated-dependencies:
- dependency-name: pypa/gh-action-pypi-publish
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@nicoddemus
Copy link
Member

Gentle ping @pytest-dev/core

Comment on lines +14 to +17
* Avasam
* Bruno Oliveira
* Ronny Pfannschmidt
* Sviatoslav Sydorenko (Святослав Сидоренко)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there's a generation issue as there's, at least, assotile too reading the changelog.

Copy link
Member

@nicoddemus nicoddemus Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh great catch!

This used to work in the past, but seems this has changed since we introduced the backport bot... I will update the script to also consider Co-authored-by, which seems something sensible to do regardless of the backport bot or not.

nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Sep 9, 2024
As noted in pytest-dev#12789, the `release.py` script did not consider `Co-authored-by` fields, and since we introduced the new backport bot, this problem became more apparent due to how the backport commit and PR are generated.

Previously, the list of authors produced by the script in the pytest-dev#12789 branch was:

```
* Avasam
* Bruno Oliveira
* Ronny Pfannschmidt
* Sviatoslav Sydorenko (Святослав Сидоренко)
```

With this script:

```
* Anthony Sottile
* Avasam
* Bruno Oliveira
* Christian Clauss
* Eugene Mwangi
* Florian Bruhin
* GTowers1
* Nauman Ahmed
* Pierre Sassoulas
* Reagan Lee
* Ronny Pfannschmidt
* Stefaan Lippens
* Sviatoslav Sydorenko (Святослав Сидоренко)
* dongfangtianyu
```
@nicoddemus
Copy link
Member

Closing due to #12795, will regenerate this PR once it gets merged.

@nicoddemus nicoddemus closed this Sep 9, 2024
nicoddemus added a commit that referenced this pull request Sep 9, 2024
As noted in #12789, the `release.py` script did not consider `Co-authored-by` fields, and since we introduced the new backport bot, this problem became more apparent due to how the backport commit and PR are generated.

Previously, the list of authors produced by the script in the #12789 branch was:

```
* Avasam
* Bruno Oliveira
* Ronny Pfannschmidt
* Sviatoslav Sydorenko (Святослав Сидоренко)
```

With this script:

```
* Anthony Sottile
* Avasam
* Bruno Oliveira
* Christian Clauss
* Eugene Mwangi
* Florian Bruhin
* GTowers1
* Nauman Ahmed
* Pierre Sassoulas
* Reagan Lee
* Ronny Pfannschmidt
* Stefaan Lippens
* Sviatoslav Sydorenko (Святослав Сидоренко)
* dongfangtianyu
```
@nicoddemus nicoddemus deleted the release-8.3.3 branch September 9, 2024 21:28
patchback bot pushed a commit that referenced this pull request Sep 9, 2024
As noted in #12789, the `release.py` script did not consider `Co-authored-by` fields, and since we introduced the new backport bot, this problem became more apparent due to how the backport commit and PR are generated.

Previously, the list of authors produced by the script in the #12789 branch was:

```
* Avasam
* Bruno Oliveira
* Ronny Pfannschmidt
* Sviatoslav Sydorenko (Святослав Сидоренко)
```

With this script:

```
* Anthony Sottile
* Avasam
* Bruno Oliveira
* Christian Clauss
* Eugene Mwangi
* Florian Bruhin
* GTowers1
* Nauman Ahmed
* Pierre Sassoulas
* Reagan Lee
* Ronny Pfannschmidt
* Stefaan Lippens
* Sviatoslav Sydorenko (Святослав Сидоренко)
* dongfangtianyu
```

(cherry picked from commit e8504ed)
nicoddemus added a commit that referenced this pull request Sep 9, 2024
As noted in #12789, the `release.py` script did not consider `Co-authored-by` fields, and since we introduced the new backport bot, this problem became more apparent due to how the backport commit and PR are generated.

Previously, the list of authors produced by the script in the #12789 branch was:

```
* Avasam
* Bruno Oliveira
* Ronny Pfannschmidt
* Sviatoslav Sydorenko (Святослав Сидоренко)
```

With this script:

```
* Anthony Sottile
* Avasam
* Bruno Oliveira
* Christian Clauss
* Eugene Mwangi
* Florian Bruhin
* GTowers1
* Nauman Ahmed
* Pierre Sassoulas
* Reagan Lee
* Ronny Pfannschmidt
* Stefaan Lippens
* Sviatoslav Sydorenko (Святослав Сидоренко)
* dongfangtianyu
```

(cherry picked from commit e8504ed)

Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants