Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add yet another flag to recompile() to avoid calling ffiplatform #81

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

nitzmahone
Copy link
Member

@nitzmahone nitzmahone commented May 28, 2024

(refiling branch commit as a PR)

fixes #76

@inklesspen
Copy link
Contributor

Is there anything I can do to help this get merged?

@arigo
Copy link
Contributor

arigo commented Aug 20, 2024

Trying to close and re-open this PR to force the checks to re-execute

@arigo arigo closed this Aug 20, 2024
@arigo arigo reopened this Aug 20, 2024
@arigo
Copy link
Contributor

arigo commented Aug 20, 2024

Nope, the musllinux tests still fail here. I'm going to assume it's unrelated to the current PR and merge anyway.

@arigo arigo merged commit 00cb9fc into main Aug 20, 2024
72 of 85 checks passed
@nitzmahone
Copy link
Member Author

Yeah, at a glance it looks like maybe the latest round of tool upgrades in the musllinux containers has broken the static libffi linkage again, and cibuildwheel recently started forcing musllinux 1.2.

On the plus side, I'm so glad @arigo came up with an easy way to alias the ffi_call stuff so an accidental non-static extension build is clearly broken instead of silently dynamic-linking in the build env, passing tests, then failing in weird ways in the real world. 🎉

IIRC Alpine has a hacky script approximation of ldconfig that doesn't cover all the bases, and getting the setuptools extension builds to uniformly respect pkg-config is ... tricky. Opened #114 to track that issue separately.

nitzmahone added a commit that referenced this pull request Sep 4, 2024
Co-authored-by: Armin Rigo <armin.rigo@gmail.com>
(cherry picked from commit 00cb9fc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants