Check if interpreter is finalizing in ~ThreadStateCreator #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace C_RECURSION_LIMIT with Py_C_RECURSION_LIMIT. * Add Py_C_RECURSION_LIMIT for Python 3.12 and older. * Disable GREENLET_USE_CFRAME on Python 3.13. * Define Py_BUILD_CORE to include pycore_frame.h.
* Don't test old Python on macos-latest. GitHub Action macos-latest was updated to arm64 which only supports recent Python versions. Continue testing old Python versions on Ubuntu. * Fix make-manylinux: set /greenlet as safe directory
Appears to hang. It was a refcounting test so those can be flaky and version dependent anyway.
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
PyEval_AddPendingCallwhile the interpreter is finalizing can lead to a segfault due to the implementation in CPython ofPyEval_AddPendingCall. This is a somewhat hacky fix to just check if it's finalizing before we try and schedule the cleanup.I say somewhat hacky, cause it's still possible to race between checking and actually calling
PyEval_AddPendingCalland end up segfaulting, but in practice so far this fix has completely solved our segfaulting issues. Arguably the most ideal fix here would be to fix this call in CPython to not segfault when the interpreter is shutting down, and just terminate the thread like it now does with the locking APIFixes #411