Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bytes -> bytearrays in read procedures #8

Closed
esel7353 opened this issue Apr 19, 2015 · 2 comments
Closed

bytes -> bytearrays in read procedures #8

esel7353 opened this issue Apr 19, 2015 · 2 comments

Comments

@esel7353
Copy link

I had to transmit a lot of 128MB waveforms from my scope to the computer, which was extremely slow. After changing all the "bytes +=" parts in the read procedures to "bytearray.append", I was able to speed the process up by a factor of 10.

So I suggest applying these changes here too.
@sauerburger
Copy link

see github.com/sauerburger/pytohn-vxi11 for the updated version

@alexforencich
Copy link
Contributor

Should be fixed now.

eltos added a commit to eltos/python-vxi11 that referenced this issue Mar 9, 2017
@eltos
Major performance improvements
2c7c60a 
Replaced byte string concatenation with bytearray extend functions.
This is ~50 times faster! (See also python-ivi#8)
@eltos eltos mentioned this issue Mar 9, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexforencich @esel7353 @sauerburger