Skip to content

Commit

Permalink
Merge pull request #6909 from radarhere/jp2_comment
Browse files Browse the repository at this point in the history
  • Loading branch information
hugovk committed Mar 22, 2023
2 parents e7fa309 + cbde5b2 commit 31e8e01
Show file tree
Hide file tree
Showing 4 changed files with 41 additions and 0 deletions.
Binary file added Tests/images/comment.jp2
Binary file not shown.
11 changes: 11 additions & 0 deletions Tests/test_file_jpeg2k.py
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,17 @@ def test_subsampling_decode(name):
assert_image_similar(im, expected, epsilon)


def test_comment():
with Image.open("Tests/images/comment.jp2") as im:
assert im.info["comment"] == b"Created by OpenJPEG version 2.5.0"

# Test an image that is truncated partway through a codestream
with open("Tests/images/comment.jp2", "rb") as fp:
b = BytesIO(fp.read(130))
with Image.open(b) as im:
pass


@pytest.mark.parametrize(
"test_file",
[
Expand Down
6 changes: 6 additions & 0 deletions docs/releasenotes/9.5.0.rst
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,12 @@ Added ``corners`` argument to ``ImageDraw.rounded_rectangle()``
``corners``. This a tuple of Booleans, specifying whether to round each corner,
``(top_left, top_right, bottom_right, bottom_left)``.

Reading JPEG comments
^^^^^^^^^^^^^^^^^^^^^

When opening a JPEG2000 image, the comment may now be read into
:py:attr:`~PIL.Image.Image.info`.

Security
========

Expand Down
24 changes: 24 additions & 0 deletions src/PIL/Jpeg2KImagePlugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,8 @@ def _open(self):
self._size, self.mode, self.custom_mimetype, dpi = header
if dpi is not None:
self.info["dpi"] = dpi
if self.fp.read(12).endswith(b"jp2c\xff\x4f\xff\x51"):
self._parse_comment()
else:
msg = "not a JPEG 2000 file"
raise SyntaxError(msg)
Expand Down Expand Up @@ -254,6 +256,28 @@ def _open(self):
)
]

def _parse_comment(self):
hdr = self.fp.read(2)
length = struct.unpack(">H", hdr)[0]
self.fp.seek(length - 2, os.SEEK_CUR)

while True:
marker = self.fp.read(2)
if not marker:
break
typ = marker[1]
if typ in (0x90, 0xD9):
# Start of tile or end of codestream
break
hdr = self.fp.read(2)
length = struct.unpack(">H", hdr)[0]
if typ == 0x64:
# Comment
self.info["comment"] = self.fp.read(length - 2)[2:]
break
else:
self.fp.seek(length - 2, os.SEEK_CUR)

@property
def reduce(self):
# https://github.com/python-pillow/Pillow/issues/4343 found that the
Expand Down

0 comments on commit 31e8e01

Please sign in to comment.