Do not update frame position until local image is found

python-pillow · Apr 16, 2022 · c811843 · c811843
1 parent c456aec
commit c811843
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 12 deletions.
diff --git a/Tests/images/comment_after_last_frame.gif b/Tests/images/comment_after_last_frame.gif
diff --git a/Tests/test_file_gif.py b/Tests/test_file_gif.py
@@ -341,16 +341,23 @@ def test_seek_rewind():
             assert_image_equal(im, expected)
 
 
-def test_n_frames():
-    for path, n_frames in [[TEST_GIF, 1], ["Tests/images/iss634.gif", 42]]:
-        # Test is_animated before n_frames
-        with Image.open(path) as im:
-            assert im.is_animated == (n_frames != 1)
-
-        # Test is_animated after n_frames
-        with Image.open(path) as im:
-            assert im.n_frames == n_frames
-            assert im.is_animated == (n_frames != 1)
+@pytest.mark.parametrize(
+    "path, n_frames",
+    (
+        (TEST_GIF, 1),
+        ("Tests/images/comment_after_last_frame.gif", 2),
+        ("Tests/images/iss634.gif", 42),
+    ),
+)
+def test_n_frames(path, n_frames):
+    # Test is_animated before n_frames
+    with Image.open(path) as im:
+        assert im.is_animated == (n_frames != 1)
+
+    # Test is_animated after n_frames
+    with Image.open(path) as im:
+        assert im.n_frames == n_frames
+        assert im.is_animated == (n_frames != 1)
 
 
 def test_no_change():

diff --git a/src/PIL/GifImagePlugin.py b/src/PIL/GifImagePlugin.py
@@ -183,8 +183,6 @@ def _seek(self, frame, update_image=True):
         if not s or s == b";":
             raise EOFError
 
-        self.__frame = frame
-
         self.tile = []
 
         palette = None
@@ -283,6 +281,8 @@ def _seek(self, frame, update_image=True):
         if interlace is None:
             # self.__fp = None
             raise EOFError
+
+        self.__frame = frame
         if not update_image:
             return