-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.12 #6941
Comments
deadsnakes decided not to support Python 3.12 on Bionic, the last 32-bit Ubuntu. We've discussed dropping support for 32-bit briefly before, so the simplest thing is for us to not release 32-bit Linux Python 3.12 wheels. |
That should be fine. Looking at a couple of projects:
https://discuss.python.org/t/dropping-32-bit-packages/5476/16?u=hugovk Looking at some numbers, here's a week's worth of Pillow file downloads from PyPI, fetched using https://github.com/ofek/pypinfo:
Filtering for the most recent release, for Python 3.11, and Linux (
|
Whilst we're here, Windows is quite low for win32:
|
I'd say just drop the 32 bit builds, especially for new pythons. |
Sounds good. So let's not create 32-bit wheels for 3.12. Do we still want to test 32-bit for 3.12? The next Pillow 10.0.0 is a major bump so it's a good opportunity to drop things:
For Linux, the Details
For Windows, Details
|
python-pillow/pillow-wheels#383 has added Python 3.12 macOS and Linux wheels, excluding 32-bit wheels, and albeit without fribidi, harfbuzz and raqm on macOS until #7167 is resolved. |
Pillow-9.5.0 works well on Python 3.12.0b2 on Windows:
|
re: #6941 (comment) I suggest we drop all the 32-bit wheels and testing. If there's a lot of demand or very good reason, we can always add something back (e.g. 3.8 on Windows has a slightly larger percentage). |
Sorry, I'm on holiday here so this is a little late -- I'm not sure if there are any remaining platforms were 32 bit is really a going concern, but I'd view it as a minor platform in the same way that we support S390 or Big Endian -- good to keep compatibility with from a correctness POV, but we're not building wheels. There's nothing in 32 bit to my knowledge where dropping it really streamlines our code. |
Okay, let's keep some representative testing of 32-bit on the CI. I'd say we can leave the docker-images changes as is.
Yeah, #7228 was mostly test bits and pieces. |
I've created #7234 to restore 32-bit support, without restoring most of the CI jobs. I've only restored 32-bit Debian 12. |
We later also restored a Windows 32-bit job - #7234 (comment) |
Pillow 10.0.0 has now been released with Python 3.12 beta wheels. |
Pillow have dropped 32-bit wheels from v10 onwards so force install of older v9 wheels since we don't want to build from src. Refs: python-pillow/Pillow#6941 (comment)
Pillow have dropped 32-bit wheels from v10 onwards so force install of older v9 wheels since we don't want to build from src. Refs: python-pillow/Pillow#6941 (comment)
Pillow 10.1.0 has now been released with Python 3.12 final wheels. |
Windows 32-bit wheels have now been restored in #7580 |
Pillow have dropped 32-bit wheels from v10 onwards so force install of older v9 wheels since we don't want to build from src. Refs: python-pillow/Pillow#6941 (comment)
Hi! |
Hi. There isn't a plan to do so, no. In general, we would encourage you to upgrade to the latest version of Pillow to receive recent security fixes. |
Tracking issue for getting the pieces into place to:
TODO
Update https://github.com/python-pillow/pillow-wheelshttps://github.com/python-pillow/Pillow/tree/main/wheelssetup.py
version check, add totox.ini
, update Python support tableNon-blockers
3.12-dev
with3.12
on GHA:3.12-dev
should pick up 3.12.0 on-flight fairly soon after release, and be added to cached images later3.11
with3.12
on AppVeyor: Updated AppVeyor to Python 3.12 #75083.11
with3.12
on Travis CI: Update Travis CI to Python 3.12 and Ubuntu 22.04 Jammy Jellyfish #7501References:
The text was updated successfully, but these errors were encountered: