Write JFIF header when saving JPEG #4639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
force-pushed
the
jfif
branch
2 times, most recently
from
150360d
to
ebc7b96
Compare
|
Is this testable? |
|
Yes, because it also turns out that this resolves #1676. So I've added a test to the commit. |
nulano
reviewed
May 25, 2020
Tests/test_file_jpeg.py
Outdated
| assert test(300) == (300, 300) | ||
| assert test(100, 200) == (100, 200) | ||
| assert test(0) is None # square pixels | ||
| for test_image_path in [TEST_FILE, "Tests/images/pil_sample_cmyk.jpg"]: |
There was a problem hiding this comment.
I would suggest using pytest.mark.parameterize in future tests, helps #4193. In my experience, it is a lot easier to both read and debug. WDYT?
There was a problem hiding this comment.
Sure, and I've pushed a commit for this. It'll just take me a while to internalise that this is the new way of doing things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3328
Pillow has some C code that sets
density_unit,X_densityandY_density. However, libjpeg states thatSo this code should tell libjpeg to write the JFIF marker.