Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move MSYS2 to GitHub Actions #4642
Move MSYS2 to GitHub Actions #4642
Changes from 5 commits
0292910
479d583
a212225
d2f90d6
82204d5
c0f7a91
21325b8
d54fee9
adde693
0b6f909
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what is causing the difference, but I am getting epsilon around 33 for both variation tests. Checking manually, I see there is a significantly different kerning after the first letter, but the output looks correct to me.
Note: MSYS2 is currently using FreeType version 2.10.2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please could you attach images for each case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
test_variation_set_by_name (epsilon 31.5340 on line 686 of PR):
a.png (MSYS):
b.png (target - variation_adobe.png):
test_variation_set_by_axes (epsilon 39.6856 on line 720 of PR):
a.png (MSYS):
b.png (target - variation_adobe_axes.png):
Basic and Raqm layout are pixel identical. In fact, it looks like there is a bug in the tests where the used
layout_engine
is not being explicitly set and defaults to Raqm in both cases.