Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TCL in Windows PyPy tests #4702

Merged
merged 1 commit into from
Jun 20, 2020
Merged

Fix TCL in Windows PyPy tests #4702

merged 1 commit into from
Jun 20, 2020

Conversation

nulano
Copy link
Contributor

@nulano nulano commented Jun 16, 2020

Before: https://github.com/python-pillow/Pillow/runs/771448368#step:22:1806

SKIPPED [4] d:\a\Pillow\Pillow\Tests\test_imagetk.py:29: TCL Error: Can't find a usable init.tcl in the following directories: 
    C:/hostedtoolcache/windows/PyPy/3.6.9/x86/lib_pypy/lib/tcl8.5 C:/hostedtoolcache/windows/PyPy/3.6.9/lib/tcl8.5 C:/hostedtoolcache/windows/PyPy/lib/tcl8.5 C:/hostedtoolcache/windows/PyPy/3.6.9/library C:/hostedtoolcache/windows/PyPy/library C:/hostedtoolcache/windows/PyPy/tcl8.5.2/library C:/hostedtoolcache/windows/tcl8.5.2/library

After: https://github.com/nulano/Pillow/runs/774933672?check_suite_focus=true#step:23:1395

Tests/test_imagetk.py::test_kw PASSED                                    [ 93%]
Tests/test_imagetk.py::test_photoimage PASSED                            [ 93%]
Tests/test_imagetk.py::test_photoimage_blank PASSED                      [ 93%]
Tests/test_imagetk.py::test_bitmapimage PASSED                           [ 93%]

On Ubuntu there is a different error (below), but adding export DISPLAY=:0.0 only gives a different error (can't connect). There is probably no X server running on Ubuntu.

SKIPPED [4] /home/runner/work/Pillow/Pillow/Tests/test_imagetk.py:29: TCL Error: no display name and no $DISPLAY environment variable

Edit: I submitted the issue to pypy, should be fixed in next release, see pypy/pypy#3247. This can be reverted then.

@radarhere
Copy link
Member

I've created nulano#6 to update Tcl to 8.6

@radarhere radarhere merged commit f2debb7 into python-pillow:master Jun 20, 2020
@nulano nulano deleted the tcl branch June 20, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants