Add release check to make sure no TODOs remain in release notes #7075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
reviewed
Apr 9, 2023
radarhere
approved these changes
Apr 9, 2023
|
If we wanted to, we could easily limit this to just check the current version of the release notes. By this point in the release checklist, we've removed But I understand the current state of this PR is more thorough. |
Co-authored-by: Andrew Murray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid mistakes like #7054.
We could use something like
grep -P TODO docs/releasenotes/[1-9]*.rstbut the-Poption isn't available in the systemgrepon macOS (see https://stackoverflow.com/a/22704387/724176), and a short script is also cross platform for Windows too.