Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppVeyor: don't download huge pillow-depends.zip #7407

Merged
merged 10 commits into from
Sep 24, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Sep 18, 2023

On AppVeyor, we're downloading a zip of the entire contents of https://github.com/python-pillow/pillow-depends/ mirror which is 851 MB and on my machine takes 6 minutes. We don't use all the files so don't need to download them all.

extract_dep of winbuild/build_prepare.py first checks if there's a local copy, and if there's not, downloads it from the upstream source.

Instead of downloading the whole mirror, I've modified extract_dep: if there's not a local copy, it first tries to download from our mirror. If that doesn't succeed, it tried the upstream source.

Also add some type hints and capitalise constants.


Also, curl has started failing to download with:

curl -fsSL -o pillow-depends.zip https://github.com/python-pillow/pillow-depends/archive/main.zip
curl: (35) schannel: next InitializeSecurityContext failed: Unknown error (0x80092013) - The revocation function was unable to check revocation because the revocation server was offline.
Command exited with code 35

https://ci.appveyor.com/project/Python-pillow/pillow/builds/48061132/job/i2a2jg124obvmoud

Adding --ssl-no-revoke fixes it:

To fix:

curl: (35) schannel: next InitializeSecurityContext failed: Unknown error (0x80092013) - The revocation function was unable to check revocation because the revocation server was offline.
@radarhere
Copy link
Member

AppVeyor has started passing again - https://ci.appveyor.com/project/Python-pillow/pillow/builds/48066083. I think that means adding --ssl-no-revoke is no longer necessary?

@hugovk
Copy link
Member Author

hugovk commented Sep 19, 2023

Good, I've dropped the --ssl-no-revoke commit.

.appveyor.yml Outdated Show resolved Hide resolved
@radarhere radarhere merged commit b723e9e into python-pillow:main Sep 24, 2023
53 checks passed
@hugovk hugovk deleted the ci-appveyor-depends branch September 24, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants