Do not preserve EXIFIFD tag by default when saving TIFF images #8110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yay295
reviewed
Jun 6, 2024
Tests/test_file_libtiff.py
Outdated
| @@ -686,12 +686,17 @@ def test_save_ycbcr(self, tmp_path: Path) -> None: | |||
| assert reloaded.tag_v2[532] == (0, 255, 128, 255, 128, 255) | |||
|
|
|||
| def test_exif_ifd(self, tmp_path: Path) -> None: | |||
There was a problem hiding this comment.
The tmp_path parameter can be removed now.
There was a problem hiding this comment.
I've updated the commit.
Yay295
reviewed
Jun 6, 2024
src/PIL/TiffImagePlugin.py
Outdated
Comment on lines
1819
to
1820
| # SAMPLEFORMAT is determined by the image format and should not be copied | ||
| # from legacy_ifd. |
There was a problem hiding this comment.
Maybe add EXIFIFD to this comment?
There was a problem hiding this comment.
I've updated the commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8106
The EXIFIFD tag is 'a pointer to the Exif IFD'. However, there's no reason why the data should be located at that very same position in the image that Pillow creates.
So this PR does not preserve it by default when saving TIFF images. The user may still provide it through an encoder argument.