Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.8 #8183

Merged
merged 8 commits into from
Jul 3, 2024
Merged

Drop support for Python 3.8 #8183

merged 8 commits into from
Jul 3, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jul 1, 2024

Python 3.8 reaches end of life in October 2024:

Pillow 11.0.0 is planned for 2024-10-15 and will drop Python 3.8:

@hugovk hugovk added the Removal Removal of a feature, usually done in major releases label Jul 1, 2024
@hugovk hugovk added this to the 11.0.0 milestone Jul 1, 2024
@@ -50,7 +50,6 @@ jobs:
fedora-39-amd64,
fedora-40-amd64,
gentoo,
ubuntu-20.04-focal-amd64,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could either update the image to upgrade the default Python version, but given Pillow 11.0 is set for release in October 2024, it's not that long until Ubuntu 20.04's EOL in April 2025 so we could just remove it?

I don't mind too much either way.

@hugovk
Copy link
Member Author

hugovk commented Jul 2, 2024

The ""Could not resolve host: mirrorlist.centos.org; Unknown error" should be fixed in a cibuildwheel release later today:

pypa/cibuildwheel#1915

@hugovk hugovk merged commit 51bd7d2 into python-pillow:main Jul 3, 2024
78 checks passed
@hugovk hugovk deleted the rm-3.8 branch July 3, 2024 06:44
@Yay295
Copy link
Contributor

Yay295 commented Jul 16, 2024

oss-fuzz/CIFuzz is hardcoded to use Python 3.8.3

https://github.com/google/oss-fuzz/blob/b4407a1aa1998de44f13fa7ed0f93259cbc2ab8e/infra/base-images/base-builder/Dockerfile#L22-L23

so the CIFuzz tests fail now with "ERROR: Package 'pillow' requires a different Python: 3.8.3 not in '>=3.9'".

https://github.com/Yay295/Pillow/actions/runs/9960735804/job/27520667252

@Yay295
Copy link
Contributor

Yay295 commented Jul 16, 2024

There's a PR to change that to 3.10.14 here: google/oss-fuzz#12027

@hugovk
Copy link
Member Author

hugovk commented Jul 16, 2024

Related issues and PRs: google/oss-fuzz#11419, google/oss-fuzz#9638, google/oss-fuzz#9532, google/oss-fuzz#11420.

In the meantime, shall we do something about the failing CI? It's training us to ignore CIFuzz failures.

For example, remove the check or make it always report passed.

@radarhere
Copy link
Member

I've created #8239 to skip it.

DonggeLiu pushed a commit to google/oss-fuzz that referenced this pull request Aug 27, 2024
Pillow's oss-fuzz is currently failing, because Pillow main has [dropped
support for Python
3.8](python-pillow/Pillow#8183).

#12027 attempts to resolve this by upgrading the base builder to Python
3.10, but the [latest status
update](#12027 (comment))
over there says that Pillow [fails in that branch
with](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-e19625fb-a984-47b1-be32-f92b4c76fc7f.txt)
> Step 17: Step 6/11 : RUN ln -s /usr/local/bin/python3
/usr/local/bin/python && ln -s /bin/true /usr/local/bin/yum_install &&
ln -s /bin/true /usr/local/bin/yum && cd $SRC/Pillow && git submodule
update --init wheels/multibuild && bash $SRC/build_depends.sh
Step 17:  ---> Running in 932abd1dc89a
Step 17: �[91mln: failed to create symbolic link
'/usr/local/bin/python': File exists

So this pull request removes the python symlink in order to try and
help.

cc @hugovk

---------

Co-authored-by: Andrew Murray <radarhere@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Removal Removal of a feature, usually done in major releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants