-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor code to support multiple project type #567
Conversation
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
77882e4
to
7bc1f68
Compare
Kudos, SonarCloud Quality Gate passed!
|
f7f838d
to
401f9a2
Compare
e625ae8
to
1aece4a
Compare
Kudos, SonarCloud Quality Gate passed!
|
7b78578
to
7f204da
Compare
Kudos, SonarCloud Quality Gate passed!
|
What's left outstanding that could get this pull request merged to add PEP 621 support to Poetry? |
Is there an ETA on when these changes will be released? PEP621 compliance is the only reason holding me back from using poetry. |
@jordantshaw If you want to try Poetry with PEP621, I made a POC as a Poetry plugin for 1.6.1. Though, is an experimental, untested, one afternoon proof-of-concept and should not be used anywhere near production code. |
@sdispater As I'm eager to use Poetry in my own CI, I'd be happy to help work on anything that needs finishing with this PR. I'm unable to see the logs for the downstream tests that failed. Could you talk a little bit about what failed and potentially what changes could resolve the CI workflow issues? |
@sdispater Is it possible to see the tests that failed on this PR? Would love to see Poetry be PEP 621 compliant and i'm willing to help where I can to help it get there. |
The failing tests are not that relevant at the moment. (You cannot see them anymore because the test run was too long ago.) In my opinion, the first step is to address python-poetry/poetry#3332 (comment) (this PR is still based on the initial proposal from python-poetry/roadmap#3 (comment)). That's basically:
I will try to work on that after the 1.8 release of Poetry if nobody beats me to it. |
I started to work on it in #708, which actually feels like "almost ready" (but I may have forgotten things). If someone wants to help:
|
Closing this for now as I am doing a branch cleanup here in upstream. |
Resolves: python-poetry/roadmap#3