[3.9] gh-123270: Replaced SanitizedNames with a more surgical fix. (GH-123354) #123432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gical fix. (pythonGH-123354) Applies changes from zipp 3.20.1 and jaraco/zippGH-124 (cherry picked from commit 2231286) (cherry picked from commit 17b77bb) Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
This was referenced Aug 28, 2024
|
Although the build fails, we can be confident that the functionality is good, because these changes were adopted by zipp 3.20.1 and tested against Python 3.9 on macOS. |
|
I don't understand why the tests are passing on Windows when two of the the 3.10 tests in #123426 were failing on Windows. |
|
Aha! It's because in Python 3.9, zipfile.Path.name still uses posixpath. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies changes from zipp 3.20.1 and jaraco/zipp#124 (cherry picked from commit 2231286) (cherry picked from commit 17b77bb)
Supersedes #123161.