Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-43888: Remove coverage builds from CI #25679

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

ammaraskar
Copy link
Member

@ammaraskar ammaraskar commented Apr 28, 2021

We introduced code coverage a while ago as part of https://bugs.python.org/issue23721 and python/core-workflow#2 but it looks like this feature isn't really utilized by many people based on searching for "codecov" on github and bpo. These builds take way longer due to the instrumentation and this is cutting into valuable CI time. The builds are now also failing on master with the new timeout mechanism.

Let's just get rid of the coverage builds and see if anyone complains :)

https://bugs.python.org/issue43888

@brettcannon
Copy link
Member

Before this can be merged there are probably some changes required over on the devguide to go with this.

@ammaraskar are you up to do a PR for that? We should probably drop the devguide mentions before we actually drop things.

@ammaraskar
Copy link
Member Author

Sounds good, let me check up on what changes need to be made in the devguide.

@vstinner
Copy link
Member

I never used this feature.

@ammaraskar
Copy link
Member Author

Brett, the only mention I found in the devguide about coverage that seemed relevant to codecov was in the committing checklist, I made a PR for that here: python/devguide#685

The rest is a guide on how to determine coverage locally which should stay in the devguide.

@Mariatta
Copy link
Member

DevGuide PR has been merged. Thanks.

@brettcannon brettcannon merged commit 726c931 into python:master Apr 30, 2021
@brettcannon
Copy link
Member

@ammaraskar thanks for the PRs!

@Mariatta thanks for merging the devguide PR!

kreathon pushed a commit to kreathon/cpython that referenced this pull request May 2, 2021
The coverage builds were consistently timing out in CI, suggesting that people were not reviewing the uploaded reports.
@RodrigoDornelles
Copy link

I missed it the same day, but now I had time to mention it, I usually check the coverage status to analyze and study more about construct languages.

@hugovk
Copy link
Member

hugovk commented Oct 2, 2023

This missed Misc/requirements-test.txt, please see #110240 to remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants