-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-45235: Revert an argparse bugfix that caused a regression #29525
Merged
rhettinger
merged 20 commits into
python:main
from
rhettinger:argparse_namespace_subparser_defaults
Nov 12, 2021
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
bbd2da9
Merge pull request #1 from python/master
rhettinger 74bdf1b
Merge branch 'master' of github.com:python/cpython
rhettinger 6c53f1a
Merge branch 'master' of github.com:python/cpython
rhettinger a487c4f
.
rhettinger eb56423
.
rhettinger cc7ba06
.
rhettinger d024dd0
.
rhettinger b10f912
merge
rhettinger fb6744d
merge
rhettinger 7f21a1c
Merge branch 'main' of github.com:python/cpython
rhettinger 7da42d4
Merge branch 'main' of github.com:rhettinger/cpython
rhettinger e31757b
Merge branch 'main' of github.com:python/cpython
rhettinger f058a6f
Merge branch 'main' of github.com:python/cpython
rhettinger 1fc29bd
Merge branch 'main' of github.com:python/cpython
rhettinger e5c0184
Merge branch 'main' of github.com:python/cpython
rhettinger 3c86ec1
Merge branch 'main' of github.com:python/cpython
rhettinger 96675e4
Merge branch 'main' of github.com:rhettinger/cpython
rhettinger de558c6
Merge branch 'main' of github.com:python/cpython
rhettinger c2278aa
Revert "bpo-45235: Fix argparse overrides namespace with subparser de…
rhettinger 994f504
Add blurb
rhettinger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
Misc/NEWS.d/next/Library/2021-11-11-13-03-17.bpo-45235.8ZbkHa.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
Reverted an argparse bugfix that caused regression in the handling of | ||
default arguments for subparsers. This prevented leaf level arguments from | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The word "This" seems a little bit ambiguous to me. It can mean this PR (#29525) or the bugfix/regression. |
||
taking precedence over root level arguments. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about we keep this test and mark is as
xfail
until we bring back a better patch for the original issue?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to leave it out. Also, any future changes will likely only go onto the main branch, so there is no value in leaving disabled tests in older versions. I would like to just do a clean revert. The open BPO issue will serve as the marker for future work to be done.