Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-95573: Fix a mistake in asyncio ssl test suppressing all logs #95687

Merged
merged 1 commit into from
Aug 5, 2022
Merged

gh-95573: Fix a mistake in asyncio ssl test suppressing all logs #95687

merged 1 commit into from
Aug 5, 2022

Conversation

fantix
Copy link
Contributor

@fantix fantix commented Aug 4, 2022 •
edited by bedevere-bot
Loading

This was originally introduced here and inherited in the cpython test suite, preventing the root reason of issues like #95573 from being easily seen.

Basically the idea of this filter is to prevent a warning saying returning true from eof_received() has no effect when using ssl, so we need to check the message instead of the logger name (like logging.Filter does).

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Aug 4, 2022
@ambv ambv added needs backport to 3.11 only security fixes skip news needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels Aug 5, 2022
@ambv
Copy link
Contributor

ambv commented Aug 5, 2022

Actually this doesn't go to 3.10, test_ssl was only added in 3.11.

@ambv ambv merged commit e1d68b3 into python:main Aug 5, 2022
@miss-islington
Copy link
Contributor

Thanks @fantix for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-95699 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 5, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 5, 2022
@fantix @miss-islington
pythongh-95573: Fix a mistake in asyncio ssl tests suppressing all lo…
cf2c3a2 
…gs (pythonGH-95687)

(cherry picked from commit e1d68b3)

Co-authored-by: Fantix King <fantix.king@gmail.com>
ambv pushed a commit that referenced this pull request Aug 5, 2022
@miss-islington @fantix
gh-95573: Fix a mistake in asyncio ssl tests suppressing all logs (GH…
0e636e4 
…-95687) (GH-95699)

(cherry picked from commit e1d68b3)

Co-authored-by: Fantix King <fantix.king@gmail.com>
@fantix fantix deleted the asyncio-test-fix-warning-suppress branch August 8, 2022 18:36
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Aug 11, 2022
@fantix @iritkatriel
pythongh-95573: Fix a mistake in asyncio ssl tests suppressing all lo…
04c1514 
…gs (python#95687)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fantix @ambv @miss-islington @bedevere-bot