-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete coverage for the qrcode package #12675
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
d454e5b
to
50c3950
Compare
This comment has been minimized.
This comment has been minimized.
50c3950
to
8f08aae
Compare
This comment has been minimized.
This comment has been minimized.
8f08aae
to
f25f83b
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Not a complete review, but we require Any
s to be documented (either using a comment or using an appropriate type alias). I noticed that you added Any
annotations to a few kwargs
arguments which are - I suspect - forwarded to another function. In this case, we could copy the arguments over (or leave kwargs
unannotated for now).
I'll review these again and document where I can. I certainly may have missed some forwarded calls in this project. However, there are some bad practices in the codebase, like a ABCs with an empty (non-abstract) |
- Reflect forwarded arguments where I missed them before - Document the remaining Any arguments.
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
You could either remove them if you think that no valid code should call |
This PR covers all of the project. This library is somewhat underdocumented so
I erred on the side of covering all modules with public names.