-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add faster versions of various runtime-checkable protocols #146
Conversation
(If this PR is accepted, I'll update #143 to talk about the new additions to |
I'd argue the speedups are quite relevant. The optimisations we've introduced into Python 3.12 were designed to address a longstanding user report where I think it's fine to decide that we don't want to bloat the API of typing_extensions, or that it's not our job to backport things just to make them faster. But I'll defend the relevance of the optimisations here to our users; I think the speedup addresses a real problem that's been a common pain point for users of typing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about it more I'm OK with merging this. Performance improvements are new features, and typing-extensions is about backporting new features.
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
This is one way of resolving the disagreement in #143. The other way would be to just revert #141. No strong opinion either way :)