Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeError on nested Annotated types where the inner type has unhashable metadata #417

Merged
merged 2 commits into from
Jun 1, 2024
Merged

Fix TypeError on nested Annotated types where the inner type has unhashable metadata #417

merged 2 commits into from
Jun 1, 2024

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Jun 1, 2024 •
edited
Loading

@AlexWaygood AlexWaygood changed the title fix unhashable Fix TypeError on nested Annotated types where the inner type has unhashable metdata Jun 1, 2024
@AlexWaygood AlexWaygood changed the title Fix TypeError on nested Annotated types where the inner type has unhashable metdata Fix TypeError on nested Annotated types where the inner type has unhashable metadata Jun 1, 2024
JelleZijlstra
JelleZijlstra approved these changes Jun 1, 2024
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's release a 4.12.1 bugfix release for this?

@AlexWaygood
Copy link
Member Author

Thanks! Let's release a 4.12.1 bugfix release for this?

Yeah, I'd vote yes. This one's pretty bad :/ (100% my fault, obviously)

@AlexWaygood AlexWaygood merged commit 8dfcf3c into main Jun 1, 2024
21 checks passed
@AlexWaygood AlexWaygood deleted the fix-unhashable branch June 1, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError on nested Annotateds with typing_extensions==4.12.0
2 participants
@AlexWaygood @JelleZijlstra