Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix]: gym 0.25 with from_pixels=True requires render_mode tp be specified #277

Closed
wants to merge 6 commits into from

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jul 17, 2022

Description

Gym introduced a BC-breaking change in their rendering API.
See issue here and PR here.

Motivation and Context

Fix this bug by making sure render_mode is always specified.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 17, 2022
@vmoens vmoens added the bug Something isn't working label Jul 17, 2022
@vmoens
Copy link
Contributor Author

vmoens commented Aug 10, 2022

Closed by #346

@vmoens vmoens closed this Aug 10, 2022
@vmoens vmoens deleted the bugfix_gym025 branch August 29, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants