Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Performance Checklist to site #2526

Merged
merged 8 commits into from
Aug 24, 2023

Conversation

sekyondaMeta
Copy link
Contributor

Adding performance checklist to site. Quick first run at the checklist.
Plan to add this checklist to FAQs page in the future as well. For now, it can be accessed through the performance page.

Fixes #(issue)
Adds to performance information

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Built pages locally to ensure they work.

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Adding performance checklist to site.
Plan to add this checklist to FAQs page in the future as well. For now, it can be accessed through the performance page.
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #2526 (79d6da1) into master (1a61d2c) will increase coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 79d6da1 differs from pull request most recent head 4f3a7ab. Consider uploading reports for the commit 4f3a7ab to get more accurate results

@@            Coverage Diff             @@
##           master    #2526      +/-   ##
==========================================
+ Coverage   72.56%   72.64%   +0.08%     
==========================================
  Files          79       79              
  Lines        3733     3733              
  Branches       58       58              
==========================================
+ Hits         2709     2712       +3     
+ Misses       1020     1017       -3     
  Partials        4        4              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@msaroufim msaroufim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments inline

@sekyondaMeta
Copy link
Contributor Author

Made the updates

@agunapal agunapal merged commit 2a386ec into pytorch:master Aug 24, 2023
13 checks passed
@sekyondaMeta sekyondaMeta deleted the perfchecklist branch September 13, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants