feat(daypicker): daypicker improvement #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minaparnian
requested review from
tysonwolker,
yogesh-jankin,
rachmulvey,
aMollusk,
a user and
NrupM
tysonwolker
previously approved these changes
Aug 1, 2019
rachmulvey
previously approved these changes
Aug 2, 2019
Minaparnian
dismissed stale reviews from rachmulvey and tysonwolker
via
95e24bc
Minaparnian
force-pushed
the
feat/daypicker
branch
from
95e24bc
to
b0e80d7
Compare
rachmulvey
previously approved these changes
Aug 6, 2019
tysonwolker
suggested changes
Aug 6, 2019
| display: 'flex' | ||
| }} | ||
| > | ||
| {(isLoadingPrice || price) && |
There was a problem hiding this comment.
Can you put a comment such as:
//TODO: change the store logic to clear prices when prices are no longer valid for a search, i.e. if you change a departure/arrival port or isClassic changes then all of the store should be invalidated and updated correctly.
That prevents this spreading the logic to children components.
Minaparnian
force-pushed
the
feat/daypicker
branch
from
b0e80d7
to
7f73403
Compare
Minaparnian
force-pushed
the
feat/daypicker
branch
from
7f73403
to
8e883e9
Compare
rachmulvey
approved these changes
Aug 6, 2019
tysonwolker
approved these changes
Aug 6, 2019
tysonwolker
pushed a commit
that referenced
this pull request
Aug 7, 2019
# [0.39.0](v0.38.0...v0.39.0) (2019-08-07) ### Features * **daypicker:** daypicker improvement ([#109](#109)) ([0b951d3](0b951d3))
|
🎉 This PR is included in version 0.39.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
rachmulvey
pushed a commit
that referenced
this pull request
Aug 20, 2019
This reverts commit 0b951d3.
rachmulvey
pushed a commit
that referenced
this pull request
Aug 20, 2019
This reverts commit 41e2d37.
rachmulvey
added a commit
that referenced
this pull request
Aug 21, 2019
* revert: "fix(daypicker): change the argument to show the prefooter disclaimer (#118)" This reverts commit 639fcdb. * revert: "feat(daypicker): Open daypicker at top of calendar. Fix keyboard navigation a11y. Improve performance of calendar by using a class inside react-window list (#119)" This reverts commit 262abc8. * revert: "fix(daypicker): add classic disclaimer to the daypicker (#116)" This reverts commit 5a78e70. * revert: "fix(daypicker): fix daypicker footer (#114)" This reverts commit 92c1ff0. * revert: "feat(daypicker): code enhancement for disclaimer message (#112)" This reverts commit 2523369. * revert: "fix(daypicker): fix prefooter && add prop for lowest points (#113)" This reverts commit f7d74e2. * revert: "feat(daypicker): daypicker improvement (#109)" This reverts commit 0b951d3.
tysonwolker
pushed a commit
that referenced
this pull request
Aug 21, 2019
rachmulvey
pushed a commit
that referenced
this pull request
Aug 21, 2019
This reverts commit 41e2d37.
rachmulvey
pushed a commit
that referenced
this pull request
Aug 21, 2019
This commit contains the following commits that were previously reverted: "fix(daypicker): change the argument to show the prefooter disclaimer (#118)" commit 705018a “fix(daypicker): add classic disclaimer to the daypicker (#116)" commit 2b4fe01 "fix(daypicker): fix daypicker footer (#114)" commit 7167f78 "feat(daypicker): code enhancement for disclaimer message (#112)" commit 4265449 “fix(daypicker): fix prefooter && add prop for lowest points (#113)" commit 5e112ba "feat(daypicker): daypicker improvement (#109)" commit 41e2d37
rachmulvey
pushed a commit
that referenced
this pull request
Aug 28, 2019
This commit contains the following commits that were previously reverted: "fix(daypicker): change the argument to show the prefooter disclaimer (#118)" commit 705018a “fix(daypicker): add classic disclaimer to the daypicker (#116)" commit 2b4fe01 "fix(daypicker): fix daypicker footer (#114)" commit 7167f78 "feat(daypicker): code enhancement for disclaimer message (#112)" commit 4265449 “fix(daypicker): fix prefooter && add prop for lowest points (#113)" commit 5e112ba "feat(daypicker): daypicker improvement (#109)" commit 41e2d37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is