Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No confirmation on "Perform file recheck" in WebUI. #19557

Open
PmNz8 opened this issue Sep 3, 2023 · 5 comments · May be fixed by #21348
Open

No confirmation on "Perform file recheck" in WebUI. #19557

PmNz8 opened this issue Sep 3, 2023 · 5 comments · May be fixed by #21348
Labels
Feature Implement new feature/subsystem WebUI WebUI-related issues/changes

Comments

@PmNz8
Copy link

PmNz8 commented Sep 3, 2023

qBittorrent & operating system versions

qBittorrent: 4.6.0 RC2 x64
Operating system: Windows 10 Pro 22H2 (10.0.19045) x64
Qt: 6
libtorrent: 2.0

What is the problem?

When clicking on "Recheck downloaded files" from WebUI there is no confirmation dialog box as in GUI version of qBittorrent. This just caused a few TB recheck as I misclicked on "Recheck" instead of "Reannounce" in WebUI.

Steps to reproduce

  1. Login into WebUI
  2. Click on any downloaded torrent to recheck its file
  3. No confirmation dialog before recheck begins.

Additional context

No response

Log(s) & preferences file(s)

No response

@glassez glassez added the WebUI WebUI-related issues/changes label Sep 3, 2023
@luzpaz
Copy link
Contributor

luzpaz commented Sep 17, 2023

@Cichy45 please elaborate what you expected to happen? Perhaps create a mockup ?

@luzpaz luzpaz added Waiting info Waiting for participants to supply more info/fulfill template requirements Feature Implement new feature/subsystem labels Sep 17, 2023
@xavier2k6
Copy link
Member

@luzpaz In main program ie GUI version (as users like to call it) under advanced we provide a confirmation on recheck option:

Screenshot 2023-09-17 161756


On a force-recheck action - user will be met with/prompted by below:

Screenshot 2023-09-17 161819


In the WebUI advanced options we don't provide a confirmation on recheck option (so user will not be met with conformation dialog box):

Screenshot 2023-09-17 161235

@luzpaz luzpaz removed the Waiting info Waiting for participants to supply more info/fulfill template requirements label Sep 17, 2023
@PmNz8
Copy link
Author

PmNz8 commented Sep 20, 2023

@luzpaz hello!
I would expect to have confirmation dialog before recheck starts, just like in GUI. So there is no chance to accidental start recheck if you miss click on "re-announce", as they have both greenish icon and are next to each other.
image

@luzpaz
Copy link
Contributor

luzpaz commented Sep 20, 2023

Any WebUI devs want to step up and implement this feature ?

@xavier2k6
Copy link
Member

@skomerko Could you look after this if a PR is still needed & any other of the 206 x WebUI related tickets

skomerko added a commit to skomerko/qBittorrent that referenced this issue Sep 16, 2024
skomerko added a commit to skomerko/qBittorrent that referenced this issue Sep 16, 2024
@skomerko skomerko linked a pull request Sep 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Implement new feature/subsystem WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants