Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay subsequent requests to the same host #19801

Merged
merged 33 commits into from
Jan 19, 2024
Merged

Delay subsequent requests to the same host #19801

merged 33 commits into from
Jan 19, 2024

Commits on Oct 25, 2023

  1. Add RSS fetch delay to settings 

    This commit only adds the RSS fetch delay setting to gui and loads it to to RssSession

Part 1 for qbittorrent#8350
    @jNullj
    jNullj committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    e79878a View commit details
    Browse the repository at this point in the history

  2. Add RSS fetch delay to webui 

    part of qbittorrent#8350
    @jNullj
    jNullj committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    5c471f0 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Add RSS fetch delay functionality 

    Add delay to requests with the same ServiceID
The delay length is based on RSS fetch delay

Fixes qbittorrent#8350
    @jNullj
    jNullj committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    ae79c73 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2023

  1. Fix code format and style 

    Co-authored-by: Chocobo1 <Chocobo1@users.noreply.github.com>
    @jNullj @Chocobo1
    jNullj and Chocobo1 committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    8510d96 View commit details
    Browse the repository at this point in the history

  2. Remove redundent code 

    Co-authored-by: Chocobo1 <Chocobo1@users.noreply.github.com>
    @jNullj @Chocobo1
    jNullj and Chocobo1 committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    fad287c View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2023

  1. Use std::chrono::seconds for fetchDelay 

    Co-authored-by: Chocobo1 <Chocobo1@users.noreply.github.com>
    @jNullj @Chocobo1
    jNullj and Chocobo1 committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    e1d5d28 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'qbittorrent:master' into feat/8350/RSS-request-delay

    @jNullj
    jNullj committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    dd94380 View commit details
    Browse the repository at this point in the history

  3. Add delay to registerSequentialService 

    Delay is per ServiceID
This removes dependency of RSS_Session from downloadmanager.
    @jNullj
    jNullj committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    7a9dcde View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Update delay for registered sequential service 

    Update delay for registered sequential download services.
User might change rss fetch delay.
This commit updates existing services with new values
to take instant effect for the change without the need for a restart.

Closes qbittorrent#8350
    @jNullj
    jNullj committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    a3c426e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'qbittorrent:master' into feat/8350/RSS-request-delay

    @jNullj
    jNullj committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    e72b20c View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Fix code format and style 

    Co-authored-by: Vladimir Golovnev <glassez@yandex.ru>
    @jNullj @glassez
    jNullj and glassez committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    590c53d View commit details
    Browse the repository at this point in the history

  2. Add missing parameter const to functions 

    Co-authored-by: Vladimir Golovnev <glassez@yandex.ru>
    @jNullj @glassez
    jNullj and glassez committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    a4eb01b View commit details
    Browse the repository at this point in the history

  3. Rearnge optionsdialog.ui for better code history 

    Revert some unneeded changes to optionsdialog.ui
intrudoced at commit e79878a
This will make diff at merge more readable
    @jNullj
    jNullj committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    59c3025 View commit details
    Browse the repository at this point in the history

  4. Rename gui label for rss fetch delay

    @jNullj
    jNullj committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    3e91435 View commit details
    Browse the repository at this point in the history

  5. Merge m_serviceDelay into m_sequentialServices 

    Avoid redundent field by joining the delay into the registered services
    @jNullj
    jNullj committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    9eb1dc2 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'qbittorrent:master' into feat/8350/RSS-request-delay

    @jNullj
    jNullj committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    b41d5f2 View commit details
    Browse the repository at this point in the history

  7. Update fetch delay label in webui

    @jNullj
    jNullj committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    bba1400 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Change m_storeFetchDelay to qint64 

    Change m_storeFetchDelay from CachedSettingValue<std::chrono::seconds>
into CachedSettingValue<qint64>
And remove redundent CachedSettingValue loading and saving for
chrono::seconds
    @jNullj
    jNullj committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    ea4ad45 View commit details
    Browse the repository at this point in the history

  2. Update m_sequentialServices comment 

    Co-authored-by: Vladimir Golovnev <glassez@yandex.ru>
    @jNullj @glassez
    jNullj and glassez committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    93c0308 View commit details
    Browse the repository at this point in the history

  3. Remove redundent registerSequentialService 

    setSequentialServiceDelay has the same functional logic as
registerSequentialService.
    @jNullj
    jNullj committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    c62f38a View commit details
    Browse the repository at this point in the history

  4. Fix m_sequentialServices usage 

    Avoid adding undesired keys to m_sequentialServices
Also avoid using a singleshot when not needed
    @jNullj
    jNullj committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    7f6556f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'qbittorrent:master' into feat/8350/RSS-request-delay

    @jNullj
    jNullj committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    eb44a21 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Move delay into handleDownloadFinished 

    Move sequentialServices delay from processRequest to
handleDownloadFinished.
Improve code readbility and clarity.
Make code more compact.

Co-authored-by: Vladimir Golovnev <glassez@yandex.ru>
    @jNullj @glassez
    jNullj and glassez committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    5722c3c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'qbittorrent:master' into feat/8350/RSS-request-delay

    @jNullj
    jNullj committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    5a7c6b6 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2024

  1. Merge branch 'qbittorrent:master' into feat/8350/RSS-request-delay

    @jNullj
    jNullj committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    a4cfe0f View commit details
    Browse the repository at this point in the history

  2. Remove redundant declaration

    @glassez
    glassez committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    b541ed6 View commit details
    Browse the repository at this point in the history

  3. Fix naming style

    @glassez
    glassez committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    f505990 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2024

  1. Avoid fetch delay clip at webui 

    Change rss_fetch_delay from int to qlonglong to avoid clipping

Co-authored-by: Chocobo1 <Chocobo1@users.noreply.github.com>
    @jNullj @Chocobo1
    jNullj and Chocobo1 committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    aa96086 View commit details
    Browse the repository at this point in the history

  2. Update spinRSSFetchDelay max value 

    Allow maximum value as user input to remove artificial limit

Co-authored-by: Chocobo1 <Chocobo1@users.noreply.github.com>
    @jNullj @Chocobo1
    jNullj and Chocobo1 committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    6fa7c4e View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2024

  1. Merge branch 'master' into feat/8350/RSS-request-delay after improvme… 

    …nt to Download Manager
    @jNullj
    jNullj committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    01509fa View commit details
    Browse the repository at this point in the history

  2. Add delay to processRequest 

    Re-add download delay for same serviceID (same domain and port)
after the download manager refactor.
    @jNullj
    jNullj committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    64d62df View commit details
    Browse the repository at this point in the history

  3. Add copyright notice

    @jNullj
    jNullj committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    64894d3 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2024

  1. Fix copyright notice

    @jNullj
    jNullj committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    8f6218e View commit details
    Browse the repository at this point in the history