Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebUI: do not follow anchor URL #21283

Merged
merged 1 commit into from
Sep 6, 2024
Merged

WebUI: do not follow anchor URL #21283

merged 1 commit into from
Sep 6, 2024

Conversation

Chocobo1
Copy link
Member

@Chocobo1 Chocobo1 commented Sep 1, 2024

Related: #21163 (comment)
Fix up 5afeecb.

@Chocobo1 Chocobo1 added the Hotfix Fix some bug(s) introduced by recently merged commit(s) label Sep 1, 2024
@Chocobo1 Chocobo1 added this to the 5.1 milestone Sep 1, 2024
@Chocobo1 Chocobo1 mentioned this pull request Sep 1, 2024
Merged
@Chocobo1 Chocobo1 requested a review from a team September 1, 2024 08:33
@Chocobo1 Chocobo1 added the WebUI WebUI-related issues/changes label Sep 1, 2024
thalieht
thalieht approved these changes Sep 1, 2024
View reviewed changes
Copy link
Contributor

@thalieht thalieht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea what it does

@Chocobo1
Copy link
Member Author

Chocobo1 commented Sep 1, 2024 •
edited
Loading

No idea what it does

Without this PR, the browser URL will change when assigning a category to a torrent (via right click menu in mainwindow) as shown in #21163 (comment). That URL change wasn't intended.

@Chocobo1 Chocobo1 merged commit 0e63b83 into qbittorrent:master Sep 6, 2024
14 checks passed
@Chocobo1 Chocobo1 deleted the webui_category_fix branch September 6, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thalieht thalieht thalieht approved these changes

@xavier2k6 xavier2k6 xavier2k6 approved these changes

Assignees
No one assigned
Labels
Hotfix Fix some bug(s) introduced by recently merged commit(s) WebUI WebUI-related issues/changes
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Chocobo1 @thalieht @xavier2k6