Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] HID console refactor #297

Merged
merged 8 commits into from
Aug 28, 2021
Merged

[Windows] HID console refactor #297

merged 8 commits into from
Aug 28, 2021

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Aug 3, 2021 •
edited
Loading

Description

Moved all the HID console logging code out of MainWindow.cs/AppDelegate.m, and into its own class.

With this, we get:

  • More reliable console connect/disconnect/report logging
  • Ability to differentiate reports from multiple connected devices
  • Ability to select a particular device to listen to, or all connected devices
  • Device list combobox on macOS

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

@fauxpark fauxpark requested a review from a team August 3, 2021 12:02
@fauxpark fauxpark mentioned this pull request Aug 18, 2021
Closed
@tzarc tzarc requested a review from a team August 24, 2021 18:34
@fauxpark fauxpark requested a review from tzarc August 27, 2021 07:55
@fauxpark fauxpark merged commit 1bf0625 into qmk:master Aug 28, 2021
@fauxpark fauxpark deleted the hid-refactor branch August 28, 2021 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
enhancement macos windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @tzarc