[Windows] Logging refactor #339

fauxpark · 2022-04-11T07:07:35Z

Description

Replaced Printing class with new subclass of RichTextBox which handles all the logging internally
Added some new MessageTypes for more fine-grained display
Improved HID report callback to only fire the delegate when a complete line has been received (as the previous behaviour of appending a newline when necessary is no longer viable - all log entries end in a newline)
Fixed a small bug when adding newly detected USB devices to the list (apparently I have been running in Release config for a while... VS only started complaining when I noticed)

fauxpark added 5 commits April 11, 2022 16:50

Subclass RichTextBox to handle logging logic

c107555

Switch log box over to new subclass

660d915

Delete Printing class

4c43de5

Make HID report callback only fire delegate when a line is completed

fc1085b

Avoid potential crash when device list is modified in foreach

7e3d7cc

fauxpark added enhancement windows labels Apr 11, 2022

fauxpark requested a review from a team April 11, 2022 07:07

Simplify report byte array to string conversion

2dabee8

fauxpark mentioned this pull request Apr 11, 2022

[macOS] Logging refactor #340

Merged

5 tasks

nooges approved these changes Apr 14, 2022

View reviewed changes

fauxpark merged commit 5f69785 into qmk:master Apr 15, 2022

fauxpark deleted the log-box-refactor branch April 15, 2022 15:44