Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cmd + shift + arrow bugs #1618

Merged
merged 5 commits into from
Jul 30, 2024
Merged

fix: cmd + shift + arrow bugs #1618

merged 5 commits into from
Jul 30, 2024

Conversation

AyushAgrawal-A2
Copy link
Collaborator

@AyushAgrawal-A2 AyushAgrawal-A2 commented Jul 26, 2024

closes #1602

fixes all 4 bugs in #1602

Copy link

qa-wolf bot commented Jul 26, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Jul 26, 2024 10:16pm

@cla-bot cla-bot bot added the cla-signed label Jul 26, 2024
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1618 July 26, 2024 20:07 Inactive
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.77%. Comparing base (f40a499) to head (1fddd56).

Additional details and impacted files
@@           Coverage Diff           @@
##               qa    #1618   +/-   ##
=======================================
  Coverage   89.76%   89.77%           
=======================================
  Files         185      185           
  Lines       34964    34978   +14     
=======================================
+ Hits        31387    31403   +16     
+ Misses       3577     3575    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1618 July 26, 2024 21:35 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1618 July 26, 2024 21:46 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1618 July 26, 2024 21:55 Inactive
@AyushAgrawal-A2 AyushAgrawal-A2 marked this pull request as ready for review July 26, 2024 22:02
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1618 July 26, 2024 22:02 Inactive
Copy link
Contributor

@luke-quadratic luke-quadratic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm from user perspective

Copy link
Collaborator

@davidkircos davidkircos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality works really great, nice PR @AyushAgrawal-A2 !

@davidfig davidfig merged commit f34ef7c into qa Jul 30, 2024
14 checks passed
@davidfig davidfig deleted the ayush/1602 branch July 30, 2024 11:01
Copy link

qa-wolf bot commented Jul 30, 2024

E2E tests

QA 2 blocking bugs

Ran Status Preview Started Run time Est. dev time saved
63 workflows Done (Details) Jul 30, 2024 at 11:17 AM (UTC) 6 minutes ~29.33 hrs
⚠️ 6 failed - your wolf pack is investigating
✅ 55 passed

Preexisting bugs

2 Blocking bugs
If you are aware of any of these bugs, you can set their priority to low and prevent them from causing a run failure.
View all blocking bugs

1 Non-blocking bug

. . . . . . . .

Re-run your E2E tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Command + Shift + Arrow bugs
4 participants