Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: maintain border state #1619

Merged
merged 6 commits into from
Aug 6, 2024
Merged

feat: maintain border state #1619

merged 6 commits into from
Aug 6, 2024

Conversation

AyushAgrawal-A2
Copy link
Collaborator

@AyushAgrawal-A2 AyushAgrawal-A2 commented Jul 27, 2024

closes #1388

  • Maintain global border menu state
  • Fix: picking colour / line-style should not clear borders
  • Border selection by user (at-least once) is required to apply changes. Just picking colour or line-style only updates menu state (Same as google sheets).

Copy link

qa-wolf bot commented Jul 27, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Jul 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Aug 2, 2024 10:59pm

Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.88%. Comparing base (5c7d808) to head (f993384).

Additional details and impacted files
@@            Coverage Diff             @@
##               qa    #1619      +/-   ##
==========================================
- Coverage   89.88%   89.88%   -0.01%     
==========================================
  Files         191      191              
  Lines       36759    36749      -10     
==========================================
- Hits        33041    33031      -10     
  Misses       3718     3718              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1619 July 27, 2024 14:03 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1619 August 2, 2024 22:23 Inactive
@davidkircos davidkircos merged commit dc72734 into qa Aug 6, 2024
14 checks passed
@davidkircos davidkircos deleted the ayush/1388 branch August 6, 2024 00:16
Copy link

qa-wolf bot commented Aug 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintain border state when border menu is open
3 participants