Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate sheet & undo delete sheet should rerun code cells #1622

Merged
merged 9 commits into from
Aug 6, 2024

Conversation

AyushAgrawal-A2
Copy link
Collaborator

@AyushAgrawal-A2 AyushAgrawal-A2 commented Jul 29, 2024

closes #1578
closes #804

  • Fix duplicate sheet should rerun code cells
  • Fix duplicate sheet does not show borders and sheet fills
  • Fix undo delete sheet should rerun code cells

@AyushAgrawal-A2 AyushAgrawal-A2 self-assigned this Jul 29, 2024
@cla-bot cla-bot bot added the cla-signed label Jul 29, 2024
Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Aug 2, 2024 10:52pm

Copy link

qa-wolf bot commented Jul 29, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1622 July 30, 2024 02:36 Inactive
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 98.63760% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.96%. Comparing base (5c7d808) to head (9d295b9).

Files Patch % Lines
quadratic-core/src/controller/send_render.rs 81.81% 2 Missing ⚠️
...roller/execution/execute_operation/execute_code.rs 50.00% 1 Missing ⚠️
...ore/src/controller/execution/run_code/get_cells.rs 50.00% 1 Missing ⚠️
quadratic-core/src/controller/operations/sheets.rs 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               qa    #1622      +/-   ##
==========================================
+ Coverage   89.88%   89.96%   +0.08%     
==========================================
  Files         191      191              
  Lines       36759    37069     +310     
==========================================
+ Hits        33041    33350     +309     
- Misses       3718     3719       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1622 August 2, 2024 22:23 Inactive
@davidkircos davidkircos merged commit 7c0eab6 into qa Aug 6, 2024
14 checks passed
@davidkircos davidkircos deleted the ayush/1578 branch August 6, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: duplicate sheet loses cell type outlines Deleting/undo delete of a sheet should rerun code cells
3 participants