Adds back cmd+r to reload the page

[davidfig]

• cmd/ctrl+r reload sheet if VITE_DEBUG=1
• shift+enter works properly - enters cell to edit; and closes the cell editor and moves up one cell

[qa-wolf]

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
quadratic	✅ Ready (Inspect)	Visit Preview	Jul 30, 2024 4:15pm

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.77%. Comparing base (ed4d7c8) to head (b86974d).

Additional details and impacted files

@@           Coverage Diff           @@
##               qa    #1624   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files         185      185           
  Lines       34978    34978           
=======================================
  Hits        31403    31403           
  Misses       3575     3575           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AyushAgrawal-A2]

@davidfig
Cmd + R / Ctrl + R is now autocomplete right. This is preventing browser default and page reload does not happen now.

quadratic/quadratic-client/src/app/keyboard/defaults.ts

Lines 120 to 124 in ed4d7c8

	action: 'fill_right',
	shortcuts: {
	mac: ['Cmd + R'],
	windows: ['Ctrl + R'],
	},

[davidfig]

Ah, that makes sense. I raised the issue in slack. If we want to have it, then I'll change this to a dev-only override.

[AyushAgrawal-A2]

Also after this PR #1612 Shortcuts should match exactly.
Earlier only part of keyboard event was checked, e.g. pressing Enter would open cell edit whether Shift or other modifier is pressed or not.
Now if the shortcut says just Enter, pressing modifiers along with it will not match that shortcut. All keys are checked.
Thanks for adding Shift+Enter

[qa-wolf]

E2E tests

QA 2 blocking bugs

Ran	Status	Preview	Started	Run time	Est. dev time saved
63 workflows	Done (Details)		Jul 30, 2024 at 4:24 PM (UTC)	2 minutes	~40.33 hrs

⚠️ 28 failed - your wolf pack is investigating

• Filter Files by Name - Shared with me

• Can Edit Member are Able to Change Permissions

• Cell Formatting

• Action Visibility

• Code Cell Outlines

• Open Formula Editor

• AI Assistant

• Help Actions

• Make Changes while Network is off

• Auto-Complete

• Create File for Team

• Spills

• Members Can Leave Team

• Create a Team

• Can View Team Member Cannot Edit Files

• Sheet Actions

• Formulas

• Manage Members

• View Actions

• Mouse Visibility

• Edit Share File Permissions

• Share File - Spreadsheet

• Connection goes down in Multiplayer Session

• Log Out

• Removed Member No Longer Can Access Team Files

• Can Stop Code Execution

• Dashboard Views - My Files

• Can Edit Team Member Can Edit Files

✅ 33 passed

• Types: Sequences, Mappings, and Sets

• File Actions

• Switching Tabs Persists Cursor

• Invite Member to Team

• Formatting

• Rename Team

• Open and Use Formula Editor

• Code Editor Displays Return

• Basic Formula Creation

• Create New File

• Code Snippets

• Zoom Options

• User Can See Other Users on File

• Share File - Dashboard

• API Calls

• Log In

• Dashboard Views - Shared with me

• Create Example

• Switch between Python and Formula

• File Actions - Dashboard

• Types: Series and Data-Frames

• References

• Can Edit Members are Able to Invite

• Import Files

• Filter Files by Name - My Files

• Open Python Editor

• Charts

• Discard Changes

• Docs page

• Drag Relative References

• Can View Members are Unable to Invite Members

• Number Formatting

• Command Palette

Preexisting bugs

2 Blocking bugs

If you are aware of any of these bugs, you can set their priority to low and prevent them from causing a run failure.
View all blocking bugs

• Currency, Scientific, Automatic formats not showing as expected

• Duplicating a file in file leads to File Validation failed screen

1 Non-blocking bug

• Cells Evaluate to Error When Running All Code Cells

. . . . . . . .

Re-run your E2E tests

[davidfig]

Yes