Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transaction would not save for manually resized rows having wrap #1743

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

AyushAgrawal-A2
Copy link
Collaborator

No description provided.

Copy link

qa-wolf bot commented Aug 20, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Aug 21, 2024 0:36am

@cla-bot cla-bot bot added the cla-signed label Aug 20, 2024
@davidfig
Copy link
Collaborator

Can you add test to catch the case that caused the problem

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1743 August 20, 2024 22:58 Inactive
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.62%. Comparing base (4b20aab) to head (f318b4d).
Report is 3 commits behind head on main.

Files Patch % Lines
...rc/controller/execution/auto_resize_row_heights.rs 95.91% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1743      +/-   ##
==========================================
- Coverage   90.63%   90.62%   -0.02%     
==========================================
  Files         192      192              
  Lines       38645    38479     -166     
==========================================
- Hits        35025    34870     -155     
+ Misses       3620     3609      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luke-quadratic
Copy link
Contributor

Fix worked: approved on functionality side

@AyushAgrawal-A2 AyushAgrawal-A2 self-assigned this Aug 20, 2024
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1743 August 21, 2024 00:22 Inactive
@davidkircos davidkircos merged commit b0ac880 into main Aug 21, 2024
14 checks passed
@davidkircos davidkircos deleted the ayush/fix_unsaved_transactions branch August 21, 2024 04:07
@AyushAgrawal-A2 AyushAgrawal-A2 restored the ayush/fix_unsaved_transactions branch August 21, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants