Basic ws server #903

ddimaria · 2023-11-29T23:07:03Z

TS types for messages
TS should only send messages once during its update loop (currently set to 15 messages/second)
basic mulitplayer cursor
basic multiplayer selection
Basic shell of a websocket server
Shared state
EnterRoom endpoint + code
MouseMove endpoint + code
Integration tests

For a separate PR

transaction sharing
multiplayer cursor shouldn't show when hovering over UI elements
better uuid for User (right now it's changed to a string)
auto generate TS types using ts-rs
Mock the socket in tests

vercel · 2023-11-29T23:07:08Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
quadratic	✅ Ready (Inspect)	Visit Preview	Dec 4, 2023 9:36pm

codecov · 2023-11-30T15:30:56Z

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (7f71bba) 88.18% compared to head (1d2b49b) 88.13%.
Report is 14 commits behind head on a-team.

Files	Patch %	Lines
quadratic-multiplayer/src/server.rs	77.77%	40 Missing ⚠️
quadratic-multiplayer/src/message.rs	91.78%	12 Missing ⚠️
quadratic-multiplayer/src/main.rs	0.00%	3 Missing ⚠️
quadratic-multiplayer/src/test_util.rs	92.50%	3 Missing ⚠️
quadratic-multiplayer/src/state.rs	96.15%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           a-team     #903      +/-   ##
==========================================
- Coverage   88.18%   88.13%   -0.05%     
==========================================
  Files          99      105       +6     
  Lines       17327    17762     +435     
==========================================
+ Hits        15280    15655     +375     
- Misses       2047     2107      +60

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

quadratic-api/src/middleware/team.ts

quadratic-client/src/gridGL/interaction/pointer/Pointer.ts

davidkircos · 2023-12-04T17:25:27Z

quadratic-multiplayer/.env.example

@@ -0,0 +1,2 @@
+HOST=127.0.0.1
+PORT=3001


I think port 443 is the one people use most of the time for WS

This is for local dev, so don't want ssl here. We should have ssl/wss for any real usage thought.

Ok. sounds good. I'll add an item to a-team so we remember before shipping

davidkircos · 2023-12-04T17:27:06Z

quadratic-client/src/ui/menus/CodeEditor/CodeEditor.tsx

+        multiplayer.sendMouseMove();
+      }}
+      onPointerMove={(e) => {
+        console.log('hi');


Cleanup before merge

Simple websocket server

30b29ab

ddimaria changed the base branch from main to a-team November 29, 2023 23:07

davidkircos temporarily deployed to quadratic-api-dev-pr-903 November 29, 2023 23:08 Inactive

vercel bot deployed to Preview November 29, 2023 23:11 View deployment

Reorganize and remove unwraps

07a6739

davidkircos temporarily deployed to quadratic-api-dev-pr-903 November 30, 2023 15:26 Inactive

vercel bot deployed to Preview November 30, 2023 15:30 View deployment

Improve NewRoom message, add MouseMove message

1e939ac

davidkircos temporarily deployed to quadratic-api-dev-pr-903 November 30, 2023 15:37 Inactive

vercel bot deployed to Preview November 30, 2023 15:40 View deployment

Add app-level state to the server

3814882

davidkircos temporarily deployed to quadratic-api-dev-pr-903 November 30, 2023 15:50 Inactive

vercel bot deployed to Preview November 30, 2023 15:53 View deployment

Add dotenv and envy for env var support

5d95595

davidkircos temporarily deployed to quadratic-api-dev-pr-903 November 30, 2023 19:09 Inactive

vercel bot deployed to Preview November 30, 2023 19:13 View deployment

Store users in a room and return room upon enter

b97633d

davidkircos temporarily deployed to quadratic-api-dev-pr-903 November 30, 2023 19:50 Inactive

vercel bot deployed to Preview November 30, 2023 19:56 View deployment

Store a socket connection for each user in a room

afbe889

davidkircos temporarily deployed to quadratic-api-dev-pr-903 November 30, 2023 19:59 Inactive

vercel bot deployed to Preview November 30, 2023 20:03 View deployment

ddimaria added 2 commits November 30, 2023 13:20

Broadcast Room message to all users in a room

1c4ba81

Genericize broadcasting + add README

bc90f03

davidkircos temporarily deployed to quadratic-api-dev-pr-903 November 30, 2023 21:45 Inactive

Fix bug in MouseMove

03e9346

vercel bot deployed to Preview November 30, 2023 21:49 View deployment

Add integration test harness, test user enter a room

de36c92

removed a weird artifact

0a001fa

davidkircos temporarily deployed to quadratic-api-dev-pr-903 December 4, 2023 15:49 Inactive

vercel bot had a problem deploying to Preview December 4, 2023 15:54 Failure

added multiplayer start to npm start

c1a55f2

davidkircos temporarily deployed to quadratic-api-dev-pr-903 December 4, 2023 16:15 Inactive

vercel bot deployed to Preview December 4, 2023 16:19 View deployment

Merge branch 'a-team' into basic-ws-server

793db5c

davidkircos temporarily deployed to quadratic-api-dev-pr-903 December 4, 2023 16:26 Inactive

vercel bot deployed to Preview December 4, 2023 16:30 View deployment

Merge branch 'a-team' into basic-ws-server

e09008c

davidkircos had a problem deploying to quadratic-api-dev-pr-903 December 4, 2023 16:45 Failure

file_id is real now; started work on transactions

69a665f

davidkircos temporarily deployed to quadratic-api-dev-pr-903 December 4, 2023 16:47 Inactive

vercel bot deployed to Preview December 4, 2023 16:55 View deployment

davidkircos reviewed Dec 4, 2023

View reviewed changes

quadratic-api/src/middleware/team.ts Show resolved Hide resolved

davidkircos reviewed Dec 4, 2023

View reviewed changes

quadratic-client/src/gridGL/interaction/pointer/Pointer.ts Show resolved Hide resolved

davidkircos reviewed Dec 4, 2023

View reviewed changes

add zod to api-deps (needed for heroku)

20d23f2

davidkircos temporarily deployed to quadratic-api-dev-pr-903 December 4, 2023 20:27 Inactive

vercel bot deployed to Preview December 4, 2023 20:31 View deployment

try api

d5288ec

davidkircos temporarily deployed to quadratic-api-dev-pr-903 December 4, 2023 21:25 Inactive

vercel bot deployed to Preview December 4, 2023 21:29 View deployment

ignore

1d2b49b

davidkircos temporarily deployed to quadratic-api-dev-pr-903 December 4, 2023 21:32 Inactive

vercel bot deployed to Preview December 4, 2023 21:36 View deployment

davidkircos merged commit 031d51c into a-team Dec 4, 2023
4 of 9 checks passed

davidkircos deleted the basic-ws-server branch December 4, 2023 22:06

ddimaria mentioned this pull request Dec 6, 2023

Multiplayer #918

Closed

28 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Basic ws server #903

Basic ws server #903

ddimaria commented Nov 29, 2023 •

edited

Loading

vercel bot commented Nov 29, 2023 •

edited

Loading

codecov bot commented Nov 30, 2023 •

edited

Loading

davidkircos Dec 4, 2023

ddimaria Dec 4, 2023

davidkircos Dec 4, 2023

davidkircos Dec 4, 2023 •

edited

Loading

		@@ -0,0 +1,2 @@
		HOST=127.0.0.1
		PORT=3001

Basic ws server #903

Basic ws server #903

Conversation

ddimaria commented Nov 29, 2023 • edited Loading

vercel bot commented Nov 29, 2023 • edited Loading

codecov bot commented Nov 30, 2023 • edited Loading

Codecov Report

davidkircos Dec 4, 2023

Choose a reason for hiding this comment

ddimaria Dec 4, 2023

Choose a reason for hiding this comment

davidkircos Dec 4, 2023

Choose a reason for hiding this comment

davidkircos Dec 4, 2023 • edited Loading

Choose a reason for hiding this comment

ddimaria commented Nov 29, 2023 •

edited

Loading

vercel bot commented Nov 29, 2023 •

edited

Loading

codecov bot commented Nov 30, 2023 •

edited

Loading

davidkircos Dec 4, 2023 •

edited

Loading