Skip to content

Commit

Permalink
Update CSS at-rule hints (adobe#14013)
Browse files Browse the repository at this point in the history
* Update CSS at-rules

Add @counter-style and @font-feature-values.
(Align colons.)

* Revert colon aligment

* Make CSS at-rule descriptions bit more consistent

* Fix the unit test for CSS At-Rule Hints
  • Loading branch information
valtlai authored and ficristo committed Jan 15, 2018
1 parent ed54f0b commit 6d848cd
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 8 deletions.
18 changes: 10 additions & 8 deletions src/extensions/default/CSSAtRuleCodeHints/AtRulesDef.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
{
"@charset": "Defines the character set used by the style sheet.",
"@import": "Tells the CSS engine to include an external style sheet.",
"@namespace": "Tells the CSS engine that all its content must be considered prefixed with an XML namespace.",
"@media": "A conditional group rule which will apply its content if the device meets the criteria of the condition defined using a media query.",
"@supports": "A conditional group rule which will apply its content if the browser meets the criteria of the given condition.",
"@page": "Describes the aspect of layout changes which will be applied when printing the document.",
"@font-face": "Describes the aspect of an external font to be downloaded.",
"@keyframes": "Describes the aspect of intermediate steps in a CSS animation sequence."
"@charset": "Defines the character set used by the style sheet.",
"@counter-style": "Defines specific counter styles that are not part of the predefined set of styles.",
"@font-face": "Describes the aspect of an external font to be downloaded.",
"@font-feature-values": "Defines common names in font-variant-alternates for feature activated differently in OpenType.",
"@import": "Tells the CSS engine to include an external style sheet.",
"@keyframes": "Describes the aspect of intermediate steps in a CSS animation sequence.",
"@media": "A conditional group rule which will apply its content if the device meets the criteria of the condition defined using a media query.",
"@namespace": "Tells the CSS engine that all its content must be considered prefixed with an XML namespace.",
"@page": "Describes the aspect of layout changes which will be applied when printing the document.",
"@supports": "A conditional group rule which will apply its content if the browser meets the criteria of the given condition."
}
2 changes: 2 additions & 0 deletions src/extensions/default/CSSAtRuleCodeHints/unittests.js
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,9 @@ define(function (require, exports, module) {
var hintList = expectHints(CSSAtRuleCodeHints.restrictedBlockHints);
verifyFirstEntry(hintList, "@charset"); // filtered on "empty string"
verifyListsAreIdentical(hintList, ["@charset",
"@counter-style",
"@font-face",
"@font-feature-values",
"@import",
"@keyframes",
"@media",
Expand Down

0 comments on commit 6d848cd

Please sign in to comment.