Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.5.7 dist tarball #31

Merged
merged 1 commit into from
Jan 6, 2015
Merged

Conversation

isaac-councill
Copy link
Contributor

Addresses issue #30

Currently, moto does not install correctly due to unpinned requirement on dicttoxml. Pypi download link to the 1.5.7 tarball is currently busted.

@pypingou
Copy link

pypingou commented Jan 6, 2015

Adding a tarball to a git repo isn't a very good idea.

If you are looking for a place to upload the tarball, pypi seems like a much better place and it's quite easy to do using python setup.py sdist upload

@isaac-councill
Copy link
Contributor Author

Agreed! I'm looking for an expedient way to fix the references published to pypi for this project. The 1.5.7 tarball is already published on pypi, but the download URL points to the dist/ folder in this github project.

I've changed this pull request to modify the download_url in setup.py instead, but someone with rights will have to publish that change to pypi.

@pypingou
Copy link

pypingou commented Jan 6, 2015

👍 for that change :-)

quandyfactory added a commit that referenced this pull request Jan 6, 2015
@quandyfactory quandyfactory merged commit b31cd20 into quandyfactory:master Jan 6, 2015
@quandyfactory
Copy link
Owner

Agreed - thank you for pointing out this issue and providing a fix that addreses it!

@quandyfactory
Copy link
Owner

I've updated the README and incremented the version to 1.5.8 and pushed it to pypi.

@isaac-councill
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants