Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup #112

Merged
merged 2 commits into from
Jun 7, 2023
Merged

cleanup #112

merged 2 commits into from
Jun 7, 2023

Conversation

gastaldi
Copy link
Member

@gastaldi gastaldi commented Jun 6, 2023

  • Remove plugin versions (already declared in quarkiverse-parent)
  • Remove compiler plugin from dependabot ignore list

@gastaldi gastaldi requested a review from majguo June 6, 2023 23:29
@majguo
Copy link
Contributor

majguo commented Jun 7, 2023

@gastaldi LGTM. Just for curiosity, why maven-compiler-plugin is not defined in section pluginManagement?

@majguo majguo merged commit bccb44d into main Jun 7, 2023
@majguo majguo deleted the cleanup branch June 7, 2023 00:42
@gastaldi
Copy link
Member Author

gastaldi commented Jun 7, 2023

@majguo looks like it was defined in the plugins but not in the pluginManagement in https://github.com/quarkiverse/quarkiverse-parent/blob/main/pom.xml#L189. Want to submit a PR fixing that?

@majguo
Copy link
Contributor

majguo commented Jun 7, 2023

@gastaldi Sure, let me open a PR a few minutes later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants