Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Maven settings from release workflow #1218

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

mjurc
Copy link
Member

@mjurc mjurc commented Jul 22, 2024

Summary

  • We set the required credentials for Maven in the setup-java action, so we don't need to use the settings anymore.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

* We set the required credentials for Maven in the setup-java action, so
  we don't need to use the settings anymore.
@mjurc mjurc requested a review from michalvavrik July 22, 2024 19:11
@mjurc mjurc self-assigned this Jul 22, 2024
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO Makes sense. Thank you

@mjurc mjurc merged commit e3cc2c0 into quarkus-qe:main Jul 22, 2024
5 checks passed
@mjurc mjurc deleted the release-fix-nonexistent-settings branch August 27, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants